fix(gstd): put non-ethexe error variants under #[cfg(...)]

[liferooter]

This commit adds #[cfg(not(feature = "ethexe"))] attribute for variants of gstd::UsageError
that cannot occur with ethexe feature.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
gstd/src/common/errors.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @liferooter, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the gstd crate's error handling by conditionally compiling specific UsageError variants. The ZeroSystemReservationAmount and ZeroReplyDeposit errors are now excluded when the ethexe feature is enabled, ensuring that only relevant error types are included based on the active feature set. This improves the precision of error reporting and optimizes the compiled code for different feature configurations.

Highlights

• Conditional Compilation: Applied #[cfg(not(feature = "ethexe"))] attribute to the ZeroSystemReservationAmount and ZeroReplyDeposit variants within the gstd::UsageError enum.

Changelog

• gstd/src/common/errors.rs
  • Added #[cfg(not(feature = "ethexe"))] attribute to the ZeroSystemReservationAmount variant.
  • Added #[cfg(not(feature = "ethexe"))] attribute to the ZeroReplyDeposit variant.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds #[cfg(not(feature = "ethexe"))] attributes to two UsageError variants that are not applicable when the ethexe feature is enabled. My review includes suggestions to also conditionally compile the associated doc comments for these variants to keep the code and its documentation consistent, which is a common best practice.

[grishasobol]

Disabling errors is not allowed like this

[StackOverflowExcept1on]

mb it make sense to add explicit enum variants, but this type even does not implement Encode, Decode. so, it's just internal repr of error.

Suggested change

	ZeroSystemReservationAmount,
	ZeroSystemReservationAmount = ???,