Add body keyframe observation support in AMPLoader#67
Open
GiulioRomualdi wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
This can be interesting for @gbionics/team-hermes and @gbionics/team-dexter |
LoreMoretti
reviewed
Jun 5, 2026
| body_pos_b = rel_pos_b_flat | ||
| body_ori_b = rel_ori_b_flat | ||
| body_lin_vel_b = self._compute_raw_derivative(rel_pos_b_flat, simulation_dt) | ||
| body_ang_vel_b = self._compute_raw_derivative(rel_ori_b_flat, simulation_dt) |
Contributor
There was a problem hiding this comment.
Isn't _compute_ang_vel more coherent here? In case, we should provide the full rotation matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support for body keyframe observations in
AMPLoader, along with corresponding tests to ensure the functionality works as expected.To use this feature, the user needs to specify the following
dataset_cfgin the agent configuration:while, in the environment configuration:
The user must ensure that
amp_obs_componentsand the observation group produce the same observation vector. Moreover, the.npyprior should contain the required keyframe poses.Notice that:
Important
The code is backward compatible: if
amp_obs_componentsis not provided, the previous observation components will be used.Tip
This feature can be used to enforce tracking of specific robot frames, such as end effectors.