Refactor dataset loader to support multi-source datasets#64
Open
hany606 wants to merge 5 commits into
Open
Conversation
Co-authored-by: Giulio Romualdi <giulio.romualdi@gmail.com>
|
Hi @hany606 can you solve the conflicts and rebase on main? |
Member
Author
|
@isorrentino Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
AMPLoaderto accept motion datasets from multiple directories via asourcesparameter, instead of being limited to a singledataset_path_root.Changes
amp_rsl_rl/utils/motion_loader.py—AMPLoader.__init__now takes a keyword-onlysources: List[Dict]parameter. Each dict has"dataset_path"(root directory) and"motions"(name→weight mapping). Removes the olddataset_path_root/datasetsparameters.amp_rsl_rl/runners/amp_on_policy_runner.py— Passessources=self.dataset_cfg["sources"]toAMPLoader. Updated docstring.example/load_amp_dataset.py— Updated to use new API.benchmarking/benchmark_download_and_loader.py— Updated to use new API.Breaking Changes
AMPLoaderno longer acceptsdataset_path_rootordatasetsas arguments. Callers must pass:Motivation
The old API forced all motions to live under a single directory. This makes it impossible to compose motion priors from different retargeting pipelines or dataset collections without copying files around. The new
sourceslist allows mixing motions from arbitrary paths.