Take II: Add GetEngineVersionInfo to GetEngineInfo (feature backport #821)#882
Open
j-rivero wants to merge 2 commits intogz-physics9from
Open
Take II: Add GetEngineVersionInfo to GetEngineInfo (feature backport #821)#882j-rivero wants to merge 2 commits intogz-physics9from
j-rivero wants to merge 2 commits intogz-physics9from
Conversation
API Changes: * Added GetVersion() method to GetEngineInfo::Engine class for retrieving engine version * Added GetEngineVersion() pure virtual method to GetEngineInfo::Implementation interface * Updated all physics engine plugins to implement version reporting: - bullet and bullet-featherstone: Parse BT_BULLET_VERSION macro to return version string (e.g., "3.24") - dartsim: Use DART_VERSION macro to return version string (e.g., "6.13.0") - tpe: Return "1.0" as version * Updated dartsim's GetEngineName() to return "dartsim" only (previously returned "dartsim-" + DART_VERSION) Generated-by: Claude Opus 4.5 --------- Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 710546a)
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
scpeters
reviewed
Feb 23, 2026
|
|
||
| ///////////////////////////////////////////////// | ||
| /// \brief This feature retrieves the physics engine version. | ||
| class GZ_PHYSICS_VISIBLE GetEngineVersionInfo : public virtual Feature |
Member
There was a problem hiding this comment.
this is now API-compatible, but we don't have GetEngineVersionInfo on main. Should we add something like class GZ_PHYSICS_VISIBLE GetEngineVersionInfo : public virtual GetEngineInfo on main?
Contributor
Author
| - bullet and bullet-featherstone: parse `BT_BULLET_VERSION` macro to return SemanticVersion(3, 24) | ||
| - dartsim: parse `DART_VERSION` macro string to SemanticVersion | ||
| - tpe: return SemanticVersion(1, 0) | ||
| * Leaves `GetEngineInfo` unchanged to avoid breaking 3rd-party plugins |
Member
There was a problem hiding this comment.
is this meant for the 9.x migration guide?
Contributor
Author
There was a problem hiding this comment.
Mostly to help us to remind that this is an alternative to #821 that we don't need to forward port. Maybe including more explicit warnings can help here.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Rework of #857 to respect API
Summary
API Changes:
GetEngineVersionInfofeature for engine version reportingGetEngineVersionInfofeature as a separate, opt-in featureGetVersion()method toGetEngineVersionInfo::EngineAPI returninggz::math::SemanticVersionGetEngineVersion()pure virtual method toGetEngineVersionInfo::ImplementationGetEngineVersionInfoin all physics engine plugins:BT_BULLET_VERSIONmacro to return SemanticVersion(3, 24)DART_VERSIONmacro string to SemanticVersionLeaves
GetEngineInfounchanged to avoid breaking 3rd-party plugins, difference from #857Test
Testing with gazebosim/gz-sim#3213, adding:
Checklist
codecheckpassed (See contributing)Generated-by: Opus/Sonnet 4.6
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.