Solver find solutions method #79
Conversation
…also be satisfactory.
…r.FindSolutions. No tests.
| // If a limit is specified and the result count exceeds it, return only the correct number of solutions. | ||
| if (limit != 0 && result.Count > limit) | ||
| { | ||
| return result.Take(limit).ToList(); |
There was a problem hiding this comment.
Is there a reason to take a limit here? Shouldn't SolveRecAll already give you the limit?
There was a problem hiding this comment.
This is to avoid edge cases where the list contains one too many solutions. I'm not sure if these cases exist, but I'm not sure how to properly test for it
There was a problem hiding this comment.
Then i think you should try to gain an understanding of that. A test like this is really error prone and probably not even needed.
|
Would be nice if you could mention the known improvements here for further documentation. Also when opening pull requests without an issue attached listing the reasons for the changes could help when reviewing. |
|
The purpose of the FindSolutions method, is to allow other wanted features late. IsProper() can be infered by asking if FingSolutions() returns more than one solution. These found solutions can also be used to create boards. I am working on a separate branch to test improvements such as:
|
Added Solver.FindSolutions(), which returns all, or a certain number of solutions to a given board. Can also randomize.
Also added Board.Validate with tests
There are several known improvements that can be made, but these will be part of a larger performance test of the solver.