-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Satisfactory check #78
base: main
Are you sure you want to change the base?
Conversation
…also be satisfactory.
/// </summary> | ||
/// <param name="board"></param> | ||
/// <returns>True if the board can be solved without trial and error guessing.</returns> | ||
public static bool IsSatisfactory(Board board) // Certain methods for eliminating candidates using inference are not currently implemented. Implementing them would make this function more acurate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented on this already in #79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Satisfactory means you can get the solutions without guess-work. Proper is when there is only one solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed in the report both of those actually mean the same thing. If you dont need guess work you can always arrive at the single solution. The only time you would ever need guess work is if there is more than one solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A sudoku with a single solution does not have to be satisfactory. It depends how you define satisfactory. How much inference is enough to make it unsatisfactory? I feel like using this method as a qualifier for satisfaction is fine, since the IsProper method is separate anyways.
Added Solver.IsSatisfactory and tests.
Also moved the success condition in SolveRec to happen earlier.
Also changed SolverTests by moving the easy board creation to its' own function, and making it satisfactory.