feat(wallets): add Turnkey signer support #12026
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rplusq
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
rplusq
force-pushed
the
feat/turnkey-signer
branch
from
3ebd55f to
d4ed301
Compare
|
Blocked by alloy-rs/alloy#2962, will update when the signer makes it into Alloy |
|
Hi @rplusq, excited for this to land in Foundry :) For the time being, can you update the PR to use Alloy's When a new release of |
rplusq
added a commit
to rplusq/foundry
that referenced
this pull request
Oct 16, 2025
Updates alloy patches to use commit e97f5be (alloy 1.0.39) instead of cc11f15 as recommended by @zerosnacks in foundry-rs#12026. This commit includes 10 additional fixes and improvements beyond cc11f15, including bug fixes for provider serialization and transaction deserialization. Patches 15 alloy crates to enable alloy-signer-turnkey: - Core: consensus, eips - Network: network, network-primitives - RPC: rpc-types, rpc-types-{engine,eth,trace} - Support: serde, genesis - Signers: signer, signer-{ledger,local,trezor,turnkey} These patches are temporary and will be removed when Foundry officially updates to alloy 1.0.39 or later. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
rplusq
added a commit
to rplusq/foundry
that referenced
this pull request
Oct 16, 2025
Updates alloy patches to use commit e97f5be (alloy 1.0.39) instead of cc11f15 as recommended by @zerosnacks in foundry-rs#12026. This commit includes 10 additional fixes and improvements beyond cc11f15, including bug fixes for provider serialization and transaction deserialization. Patches 15 alloy crates to enable alloy-signer-turnkey: - Core: consensus, eips - Network: network, network-primitives - RPC: rpc-types, rpc-types-{engine,eth,trace} - Support: serde, genesis - Signers: signer, signer-{ledger,local,trezor,turnkey} These patches are temporary and will be removed when Foundry officially updates to alloy 1.0.39 or later. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
rplusq
force-pushed
the
feat/turnkey-signer
branch
from
b91271c to
78ac1ea
Compare
|
@zerosnacks Followed your advice but with |
|
Hi @rplusq , https://crates.io/crates/alloy/1.0.41 has just been released |
|
@zerosnacks updated here #12149. Using that as base and will rebase once merged. |
rplusq
force-pushed
the
feat/turnkey-signer
branch
from
15a7037 to
8d2e0eb
Compare
Add Turnkey as a remote signer option alongside AWS KMS and GCP KMS. Key changes: - Added alloy-signer-turnkey dependency to foundry-wallets - Implemented Turnkey wallet CLI args and initialization logic - Added turnkey feature flags to cast and forge - Updated Dockerfile and Makefile to include turnkey in release builds Fixed forge wallet feature flags: - Moved foundry-wallets from dev-dependencies to dependencies in forge/Cargo.toml - This fixes an issue where aws-kms, gcp-kms, and turnkey features were defined but non-functional when using cargo run with --features flags - The features worked in release builds (via Makefile) but not in local dev - This aligns forge with cast, which already had foundry-wallets as a regular dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rplusq
force-pushed
the
feat/turnkey-signer
branch
from
8d2e0eb to
2864d03
Compare
mattsse
approved these changes
Oct 17, 2025
|
Will have to wait, needs to remove native-tls from turnkey client, update alloy and then update here again. |
|
Opened tkhq/rust-sdk#62, will then PR into alloy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
alloy-signer-turnkeydependency tofoundry-walletsturnkeyfeature flags to cast and forgeBug Fix: forge wallet features
Made
foundry-walletsan optional dependency inforge/Cargo.tomland updated feature definitions.Issue: The
aws-kms,gcp-kms, andturnkeyfeatures were defined but non-functional when usingcargo run --features forge/turnkey. The features only worked in release builds via Makefile.Root cause:
foundry-walletswas a dev-dependency, so feature flags had no effect. Additionally, it was unconditionally compiled in the default build despite being feature-gated, causing unused dependency warnings.Fix:
foundry-walletsan optional dependency:foundry-wallets = { workspace = true, optional = true }turnkey = ["dep:foundry-wallets", "foundry-wallets/turnkey"]lib.rsto only use the crate when features are enabledThis aligns forge with cast's wallet handling and resolves clippy warnings about unused dependencies.
Testing
🤖 Generated with Claude Code