feat(signer-turnkey): bump to 0.5 and add to main alloy package #3043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rplusq
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
rplusq
changed the title
## Changes - Bump turnkey_client from 0.4 to 0.5 (removes OpenSSL dependency) - Add alloy-signer-turnkey to workspace dependencies - Add alloy-signer-turnkey to main alloy package - Add signer-turnkey feature flag matching AWS/GCP pattern - Add turnkey module re-export in signers - Add turnkey to eip712 feature for EIP-712 signing support This makes the Turnkey signer consistent with AWS KMS and GCP KMS signers, and enables integration with Foundry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rplusq
force-pushed
the
deps/bump-turnkey-client
branch
from
8b321e9 to
05e8339
Compare
|
Thanks! Apologies for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
turnkey_clientdependency from 0.4 to 0.5alloy-signer-turnkeyto main alloy package re-exportsMotivation
Version 0.5.0 removes OpenSSL from the dependency tree by switching to rustls by default. This resolves
cargo-denyconflicts in projects like Foundry that have workspace-wide bans on OpenSSL dependencies. This version bump is required for Foundry integration.Additionally, the Turnkey signer should be exposed in the main
alloypackage for consistency with other remote signers (AWS KMS, GCP KMS). This is a separate improvement for better developer experience.Changes
turnkey_clientfrom0.4to0.5incrates/signer-turnkey/Cargo.tomlalloy-signer-turnkeyto workspace dependencies in rootCargo.tomlalloy-signer-turnkeydependency tocrates/alloy/Cargo.tomlsigner-turnkeyfeature flag following the pattern ofsigner-awsandsigner-gcpcrates/alloy/src/lib.rssigners moduleeip712feature for EIP-712 signing supportReferences
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]