Skip to content

fix: provide database connection options to fx container for circuit breaker #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flemzord wants to merge 1 commit into
base: release/v3.1
Choose a base branch
from
Open

fix: provide database connection options to fx container for circuit breaker #628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ func commonOptions(cmd *cobra.Command) (fx.Option, error) {
}),
health.Module(),
publish.FXModuleFromFlags(cmd, service.IsDebug(cmd)),
fx.Supply(connectionOptions),
Copy link
Contributor

@fguery fguery Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not doing the same as in main?

		fx.Provide(func() *bunconnect.ConnectionOptions {
			return connectionOptions
		}),

Copy link
Contributor

@fguery fguery Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it might be why the tests fails :D

licence.FXModuleFromFlags(cmd, ServiceName),
storage.Module(cmd, *connectionOptions, configEncryptionKey),
profiling.FXModuleFromFlags(cmd),
Expand Down
Loading