fix: provide database connection options to fx container for circuit breaker #628
Conversation
…ainer The circuit breaker storage module requires *bunconnect.ConnectionOptions but this dependency was not provided to the fx container, causing injection failures. This fix adds fx.Supply(connectionOptions) to ensure the circuit breaker module can properly create its database connection.
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
flemzord
changed the title
| }), | ||
| health.Module(), | ||
| publish.FXModuleFromFlags(cmd, service.IsDebug(cmd)), | ||
| fx.Supply(connectionOptions), |
There was a problem hiding this comment.
why not doing the same as in main?
fx.Provide(func() *bunconnect.ConnectionOptions {
return connectionOptions
}),
There was a problem hiding this comment.
actually it might be why the tests fails :D
Add
fx.Supply(connectionOptions)to provide DB connection options to the fx container.The Circuit Breaker storage module requires
*bunconnect.ConnectionOptionsas an fx dependency, which was previously not supplied, preventing it from creating its DB connection when active.