fix(server): make uvicorn workers>1 work (factory + spawn for CUDA)#1141
Draft
vladlearns wants to merge 3 commits intofishaudio:mainfrom
Draft
fix(server): make uvicorn workers>1 work (factory + spawn for CUDA)#1141vladlearns wants to merge 3 commits intofishaudio:mainfrom
vladlearns wants to merge 3 commits intofishaudio:mainfrom
Conversation
Author
|
@leng-yue , @PoTaTo-Mika , @Stardust-minus , @Whale-Dolphin , may you guys take a look, please. Thank you! |
Author
|
@Juanma-t, this should help you |
Author
|
@leng-yue , @PoTaTo-Mika , @Stardust-minus , @Whale-Dolphin, I'm converting it to draft, for it not to be automatically closed. I've tested everything out, everything works. Please, take a look, it still needs you attention. Thank you! |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES:
#1142
#1143
Bugs sum up
__main__only exist in the parent process, so workers would miss that config and fall back to defaults/break.What I changed
QA