Fix #1143: [BUG] only one worker runs with workers > 1 due to CUDA fork#1152
Open
danielalanbates wants to merge 1 commit intofishaudio:mainfrom
Open
Fix #1143: [BUG] only one worker runs with workers > 1 due to CUDA fork#1152danielalanbates wants to merge 1 commit intofishaudio:mainfrom
danielalanbates wants to merge 1 commit intofishaudio:mainfrom
Conversation
When uvicorn spawns multiple worker processes it uses multiprocessing (fork by default on Linux). Passing an already-constructed app instance to uvicorn.run() means every worker inherits the parent process's state, including any CUDA handles that were opened during import. CUDA does not survive a fork(), so all but one worker die immediately at startup. The fix is to: 1. Expose `api` and `app` at module level so they are reachable via an import string. 2. Pass the import string "tools.api_server:app" to uvicorn.run() when workers > 1. Each spawned worker then imports the module independently, creating a fresh CUDA context of its own. Single-worker deployments continue to receive the app instance directly (no behaviour change). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
#1141 - the fix is here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1143
Summary
This PR fixes: [BUG] only one worker runs with workers > 1 due to CUDA fork issues
Changes
Testing
Please review the changes carefully. The fix was verified against the existing test suite.
This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!