Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: debugging improvements #3890

Merged
merged 5 commits into from
Feb 17, 2025
Merged

datacube: debugging improvements #3890

merged 5 commits into from
Feb 17, 2025

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Feb 11, 2025

No description provided.

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 58d3129

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@finos/legend-data-cube Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-data-cube Minor
@finos/legend-application-studio Patch
@finos/legend-server-sdlc Patch
@finos/legend-shared Patch
@finos/legend-graph Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-code-editor Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-lego Patch
@finos/legend-server-depot Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-server-showcase Patch
@finos/legend-storage Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 4.57227% with 1941 lines in your changes missing coverage. Please review.

Project coverage is 46.16%. Comparing base (8ec1f60) to head (e20d45f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ents/view/editor/DataCubeEditorDimensionsPanel.tsx 0.00% 606 Missing ⚠️
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 365 Missing ⚠️
...lder/source/LocalFileDataCubeSourceBuilderState.ts 0.00% 178 Missing and 1 partial ⚠️
.../view/editor/DataCubeEditorDimensionsPanelState.ts 0.00% 133 Missing and 1 partial ⚠️
...c/stores/editor/editor-state/ModelImporterState.ts 8.51% 129 Missing ⚠️
...rc/components/core/DataCubeExecutionErrorAlert.tsx 24.62% 101 Missing ⚠️
...ph-manager/protocol/pure/v1/V1_PureGraphManager.ts 15.11% 73 Missing ⚠️
.../builder/source/LocalFileDataCubeSourceBuilder.tsx 0.00% 59 Missing ⚠️
...data-cube/src/stores/LegendDataCubeDuckDBEngine.ts 0.00% 47 Missing ⚠️
...c/components/editor/editor-group/ModelImporter.tsx 2.77% 35 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3890      +/-   ##
==========================================
- Coverage   46.45%   46.16%   -0.29%     
==========================================
  Files        2258     2262       +4     
  Lines      395067   396395    +1328     
  Branches    17270    11003    -6267     
==========================================
- Hits       183535   183011     -524     
- Misses     211092   212943    +1851     
- Partials      440      441       +1     
Files with missing lines Coverage Δ
...raph/src/graph-manager/AbstractPureGraphManager.ts 94.08% <100.00%> (+0.05%) ⬆️
...otocol/pure/v1/engine/execution/V1_ExecuteInput.ts 100.00% <100.00%> (ø)
...ackages/legend-shared/src/format/FormatterUtils.ts 89.79% <100.00%> (-0.05%) ⬇️
...iew/editor/DataCubeEditorColumnPropertiesPanel.tsx 4.50% <0.00%> (ø)
...cube/src/stores/core/model/CachedDataCubeSource.ts 75.00% <50.00%> (+0.92%) ⬆️
...end-data-cube/src/stores/view/DataCubeViewState.ts 15.01% <0.00%> (-0.05%) ⬇️
...ackages/legend-server-sdlc/src/SDLCServerClient.ts 0.00% <0.00%> (ø)
...builder/source/AdhocQueryDataCubeSourceBuilder.tsx 0.00% <0.00%> (ø)
.../src/stores/builder/LegendDataCubeBuilderStore.tsx 0.00% <0.00%> (ø)
...legend-server-sdlc/src/models/version/VersionId.ts 0.00% <0.00%> (ø)
... and 26 more

... and 113 files with indirect coverage changes

@akphi akphi force-pushed the dt62 branch 4 times, most recently from 3d9293c to 58d3129 Compare February 16, 2025 17:22
@akphi akphi marked this pull request as ready for review February 16, 2025 18:52
@akphi akphi requested a review from a team as a code owner February 16, 2025 18:52
@akphi akphi changed the title datacube: dimensions datacube: debugging improvements Feb 16, 2025
@akphi akphi merged commit 6d3fd5a into finos:master Feb 17, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants