datacube: minor cleanups

finos · Feb 11, 2025 · a7777b1 · a7777b1
1 parent c0a5458
commit a7777b1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/brown-keys-happen.md b/.changeset/brown-keys-happen.md
@@ -0,0 +1,3 @@
+---
+'@finos/legend-data-cube': patch
+---
diff --git a/packages/legend-data-cube/src/stores/core/DataCubeEngine.tsx b/packages/legend-data-cube/src/stores/core/DataCubeEngine.tsx
@@ -279,7 +279,9 @@ export abstract class DataCubeEngine {
     return undefined;
   }
 
-  async disposeCache(source: CachedDataCubeSource) {}
+  async disposeCache(source: CachedDataCubeSource) {
+    // do nothing
+  }
 
   // ---------------------------------- APPLICATION ----------------------------------
 

diff --git a/packages/legend-data-cube/src/stores/view/DataCubeViewState.ts b/packages/legend-data-cube/src/stores/view/DataCubeViewState.ts
@@ -261,6 +261,7 @@ export class DataCubeViewState {
         });
 
         if (
+          this.grid.isCachingEnabled &&
           this.settingService.getBooleanValue(
             DataCubeSettingKey.GRID_CLIENT__SHOW_AUTO_ENABLE_CACHE_PERFORMANCE_WARNING,
           )

diff --git a/scripts/test/jest.config.base.js b/scripts/test/jest.config.base.js
@@ -175,7 +175,7 @@ export const getBaseJestConfig = (isGlobal) => {
 };
 
 export const getBaseJestProjectConfig = (projectName, packageDir) => {
-  let testMatch = [];
+  const testMatch = [];
   if (!process.env.TEST_GROUP) {
     testMatch.push(
       `<rootDir>/${packageDir}/**/__tests__/**/*(*.)test.[jt]s?(x)`,
-Original file line number
+Diff line change
@@ Expand Up / @@ -261,6 +261,7 @@ export class DataCubeViewState { @@
             });
             if (
+              this.grid.isCachingEnabled &&
               this.settingService.getBooleanValue(
                 DataCubeSettingKey.GRID_CLIENT__SHOW_AUTO_ENABLE_CACHE_PERFORMANCE_WARNING,
               )
@@ Expand Down @@