Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Added root files to projects to make them easier to edit #16815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Code Quality: Added root files to projects to make them easier to edit #16815

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d856ebd
Include tooling files in project
Lamparter Feb 15, 2025
161f92e
Merge branch 'main' into include-primitives
Lamparter Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,9 @@
<MinimalWindowsVersion>10.0.19041.0</MinimalWindowsVersion>
<WindowsSdkPackageVersion>10.0.22621.57</WindowsSdkPackageVersion>
</PropertyGroup>
<ItemGroup>
<None Include="$(MSBuildThisFileDirectory)\.editorconfig" />
<None Include="$(MSBuildThisFileDirectory)\Directory.Build.props" />
<None Include="$(MSBuildThisFileDirectory)\Directory.Packages.props" />
</ItemGroup>
Comment on lines +10 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make them appear on all projects. Instead you should add them as solution items.
I would recommend holding up the change until we migrate to slnx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's a better experience to add them to the project directly as they apply to every project
If it was an explicit .props file that was in the actual project structure then I would add them to the solution, though since these files apply everywhere it makes sense to put them inside every project as None.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create a virtual folder and add them to it in the solution file.

</Project>
Loading