Code Quality: Added root files to projects to make them easier to edit #16815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hez2010
suggested changes
Feb 15, 2025
Comment on lines
+9
to
+13
| <ItemGroup> | ||
| <None Include="$(MSBuildThisFileDirectory)\.editorconfig" /> | ||
| <None Include="$(MSBuildThisFileDirectory)\Directory.Build.props" /> | ||
| <None Include="$(MSBuildThisFileDirectory)\Directory.Packages.props" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
This will make them appear on all projects. Instead you should add them as solution items.
I would recommend holding up the change until we migrate to slnx.
There was a problem hiding this comment.
I'm aware of that
There was a problem hiding this comment.
IMO it's a better experience to add them to the project directly as they apply to every project
If it was an explicit .props file that was in the actual project structure then I would add them to the solution, though since these files apply everywhere it makes sense to put them inside every project as None.
There was a problem hiding this comment.
You can create a virtual folder and add them to it in the solution file.
Signed-off-by: Lamparter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Directory.Packages.props,Directory.Build.propsand.editorconfigto all projects asNoneto make them appear in Solution Explorer. This makes them easier to edit.