Skip to content

Remove popup dialog #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanweeks merged 2 commits into from
Jul 8, 2025
Merged

Remove popup dialog #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd7f2c
Comment out the `jump-to-chart` dialog
luthian Jul 8, 2025
284f403
Adjust the font size of the “step-1” text
luthian Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
$(".facet").on("change", function (thefacet) {
var a = find_facet($(this).attr("facetid"));

$('.jump-to-chart').hide();
// $('.jump-to-chart').hide();

a.selected = ! a.selected;
if (! a.selected) {
Expand Down Expand Up @@ -428,15 +428,15 @@
$('html, body').animate({
scrollTop: $(".comparisonchart-wrapper-wrapper").offset().top
}, 500);
$(".jump-to-chart").hide();
// $(".jump-to-chart").hide();
});

$( "#modularstorage-services" ).on('click', '.cardcheckbox', function() {
$('.jump-to-chart').show();
// $('.jump-to-chart').show();
var service_count = $('.cardcheckbox:checked').length;
if (service_count < 1) {
$('#container34').hide();
$(".jump-to-chart").hide();
// $(".jump-to-chart").hide();
} else {
$('#container34').show();
}
Expand All @@ -455,15 +455,15 @@
$('.btn-select-all').click(function(){
$('.cardcheckbox').not('.mismatch .cardcheckbox').prop('checked', true);
evaluate_services();
$('.jump-to-chart').show();
// $('.jump-to-chart').show();
$('#container34').show();
listenForScrollEvent($('#comparisonchart tbody'));
});

$('.btn-select-none').click(function(){
$('.cardcheckbox').prop('checked', false);
evaluate_services();
$('.jump-to-chart').hide();
// $('.jump-to-chart').hide();
$('#container34').hide(); // not sure we want this
});

Expand Down
11 changes: 9 additions & 2 deletions sass/_customizations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ footer a {

.cwd-scrolling-table .floating-row-header {
background-color: lighten($medium-gray, 50);
& > div {
display: flex;
align-items: center;
}
}

.hero,
Expand Down Expand Up @@ -172,8 +176,11 @@ footer a {
.services-header .btn-secondary {
margin: 4px 0;
}
.step-1 + button {
margin-top: 1.75em;
.step-1 {
font-size: larger;
& + button {
margin-top: 1.75em;
}
}

.title {
Expand Down
4 changes: 2 additions & 2 deletions templates/finder.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
</div>
</div>

<div class="jump-to-chart">
{# <div class="jump-to-chart">
<div class="container">
<div class="media">
<div class="media-body">
Expand All @@ -81,7 +81,7 @@
</div>
</div>
</div>
</div>
</div> #}
<div style="margin-top:25px;">
<p class="cert"><span class="fa fa-comments"></span>If you experience any issues with the tool,
please email rchelp@rc.fas.harvard.edu</p>
Expand Down