Merged
Conversation
- Both the HTML itself and all the hide/show jQuery
- And center the row descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this
This pull request includes changes to deprecate the "jump-to-chart" feature and introduce minor styling updates to improve the UI. The most important changes involve commenting out or removing functionality related to "jump-to-chart" in both JavaScript and HTML files, as well as adding new styles and adjustments in the SCSS file for better visual alignment.
Deprecation of "jump-to-chart" feature:
js/app.js: Commented out all instances of$('.jump-to-chart').hide()and$('.jump-to-chart').show()to disable the feature without fully removing it. [1] [2] [3]templates/finder.html.twig: Commented out the HTML structure for the "jump-to-chart" section, effectively removing it from the rendered page. [1] [2]UI styling updates:
sass/_customizations.scss:display: flexandalign-items: centerto.cwd-scrolling-table .floating-row-header > divfor better alignment of header content..step-1to increase font size and adjusted the margin of adjacent buttons for improved spacing.