chore: Fix some issues with static analysis#88

Draft

jason-famedly wants to merge 22 commits intomainfrom

jason/tech-debt-1

Commits on Apr 29, 2026

fix: correct for "error: Value of type "Collection[str]" is not indexable" by typing dict as JsonDict, which allows for values of Any
jason-famedly
committed
chore: all functions should have return typing. This should be all the None returns
jason-famedly
committed
chore: all functions should have return typing. This should be all the ones that handle dictionaries that translate to JSON
jason-famedly
committed
chore: type the global admins object used for the ModuleApiTestCase class mocks
jason-famedly
committed
chore: correct arg typing on parse_auth(), and remove potential shadowing of built-in "type"
jason-famedly
committed
chore: Move the auth header generation classes to the types.py file and make them a Protocol instead of a Union
jason-famedly
committed
chore: Remove explicit Deferred creation as these functions are regular awaitables
jason-famedly
committed
chore: remove unnecessary Optional typing import
jason-famedly
committed
chore: correct typing and arg name on __init__() for TokenAuthenticator
jason-famedly
committed
chore: resource rendering functions return bytes
jason-famedly
committed
chore: move all rest Resource to their own file
jason-famedly
committed
chore: break nested class definitions out to top level
jason-famedly
committed
chore: correct typing from 'object' to 'OIDCConfig' to fix mypy warning about unknown attributes
jason-famedly
committed
chore: Resources should have a super() call to establish it's 'children' attribute(I do not believe it is used by the token authenticator)
jason-famedly
committed
chore: correct argument type for parse_validator() to reflect that it can be a list as well
jason-famedly
committed
chore: clean up the signatures of the four main auth checking functions to unify the response types and use future annotations
jason-famedly
committed
refactor: mount 'hs.mockmod' onto the ModuleApiTestCase directly and give it a proper type for the attribute
jason-famedly
committed
chore: add guaranteed attributes to TokenAuthenticatorConfig and type the argument for verify_jwt_based_cfg()
jason-famedly
committed
chore: avoid attribute magic initializing TokenAuthenticator, these attributes always exist now(even if they are None)
jason-famedly
committed
chore: refactor and unify how config attributes are pulled out and named inside each checker function
jason-famedly
committed
fix: typing on test construction for JWE token. One is ignored, the other is a JSON string(was a dict, which was coercable)
jason-famedly
committed
chore: Strictly type the auth_checkers object passed to register_password_auth_provider_callbacks() to guarantee it does not drift
jason-famedly
committed