chore: Fix some issues with static analysis#88
Draft
jason-famedly wants to merge 22 commits intomainfrom
Draft
Conversation
…able" by typing dict as JsonDict, which allows for values of Any
…e ones that handle dictionaries that translate to JSON
…wing of built-in "type"
…nd make them a Protocol instead of a Union the goal of this is to remove things from generic 'utils' style junk drawers and have them be clearly labeled
…ng about unknown attributes
…en' attribute(I do not believe it is used by the token authenticator)
… can be a list as well
…ns to unify the response types and use future annotations Also, was using the module_api module to import the LoginResponse and JsonDict. They are present in that module but do not show up correctly for static analysis. Import them directly
…give it a proper type for the attribute
… the argument for verify_jwt_based_cfg()
…ttributes always exist now(even if they are None)
…med inside each checker function "config -> jwt_cfg", for example. Assertions are present to help mypy figure out that these values can not be None here
…ther is a JSON string(was a dict, which was coercable)
…word_auth_provider_callbacks() to guarantee it does not drift
jason-famedly
force-pushed
the
jason/tech-debt-1
branch
from
330c277 to
891cf93
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 73.28% 73.81% +0.53%
==========================================
Files 5 7 +2
Lines 756 779 +23
Branches 145 146 +1
==========================================
+ Hits 554 575 +21
- Misses 143 145 +2
Partials 59 59
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to use
hatch fmtstatic analysis tooling(such asmypy), need to fix up a few things.This part is a general and broad house cleaning that should reduce some boilerplate issues
"The easy parts"