Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken OSS CI and tests #85

Closed
wants to merge 1 commit into from
Closed

Fix broken OSS CI and tests #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions distributed_shampoo/utils/tests/shampoo_preconditioner_list_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,22 +617,21 @@ def test_precondition_grad(self) -> None:

# Compare the results of preconditioning the gradient with both setups for different contract dimensions.
for dims in (([0], [0]), ([0], [1])):
torch.testing.assert_close(
self._preconditioner_list._precondition_grad(
grad=grad,
preconditioned_dims_selector=experimental_preconditioned_dims_selector,
preconditioner_list=experimental_preconditioner_list,
dims=dims,
),
self._preconditioner_list._precondition_grad(
grad=grad,
preconditioned_dims_selector=control_preconditioned_dims_selector,
preconditioner_list=control_preconditioner_list,
dims=dims,
),
rtol=0.0,
atol=0.0,
)
with self.subTest(dims=dims):
torch.testing.assert_close(
self._preconditioner_list._precondition_grad( # type: ignore[attr-defined]
grad=grad,
preconditioned_dims_selector=experimental_preconditioned_dims_selector,
preconditioner_list=experimental_preconditioner_list,
dims=dims,
),
self._preconditioner_list._precondition_grad( # type: ignore[attr-defined]
grad=grad,
preconditioned_dims_selector=control_preconditioned_dims_selector,
preconditioner_list=control_preconditioner_list,
dims=dims,
),
)

def test_numel_list(self) -> None:
self.assertEqual(self._preconditioner_list.numel_list, (8, 16, 10))
Expand Down