Fix broken OSS CI and tests #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70228950 |
Summary: 1. Ignore mypy type errors in shampoo_preconditioner_list_test.py because `mypy` is complaining about `attr-defined` issue due to facebookresearch@66f348c. This diff tries to ignore the mypy errors. 2. Relax the`rtol` and `atol` constraints to fix CI test failures. Differential Revision: D70228950
tsunghsienlee
force-pushed
the
export-D70228950
branch
from
63f4ae2 to
706c4d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70228950 |
tsunghsienlee
changed the title
tsunghsienlee
added a commit
to tsunghsienlee/optimizers
that referenced
this pull request
Feb 26, 2025
Summary: 1. Ignore mypy type errors in shampoo_preconditioner_list_test.py because `mypy` is complaining about `attr-defined` issue due to facebookresearch@66f348c. This diff tries to ignore the mypy errors. 2. Relax the`rtol` and `atol` constraints to fix CI test failures. Differential Revision: D70228950
|
This pull request has been merged in 4bd0f72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
because
mypyis complaining aboutattr-definedissue due to 66f348c. This diff tries to ignore the mypy errors.rtolandatolconstraints to fix CI test failures.Differential Revision: D70228950