[Compiler] Improve error for calculate in render useEffect validation

[jorge-cab]

Summary:
Change error and update snapshots

The error now mentions what values are causing the issue which should provide better context on how to fix the issue

---

Stack created with Sapling. Best reviewed with ReviewStack.

• -> [Compiler] Improve error for calculate in render useEffect validation #34580
• [Compiler] Don't throw calculate in render if the blamed setter is used outside of the effect #34579
• [Compiler] Don't throw calculate in render when there is a global function call in the effect #34578
• [Compiler] Don't throw calculate in render when there is a ref in the effect #34577
• [Compiler] Change ValidateNoDerivedComputationsInEffect logic to track prop and local state derived values variables and #34575
• [Compiler] ValidateNoDerivedComputationsInEffects test cases #34574

[mofeiZ]

This is currently overwriting the operand's derivationEntry. Instead, we want to merge the operand's existing entry with the current instruction's typeOfValue

[mofeiZ]

This is where alias maps would come in handy. We technically don't need to mark captured values as 'fromProps' or 'fromState' unless there is a later mutation. This is a bit complex to model though, so we can skip for now

const x = {} ;
const arr = [x, props.foo];
read(x);   // <- known to be not from state or props

const x = {} ;
const arr = [x, props.foo];
write(arr);
read(x);   // <- might be from state or props

[mofeiZ]

Let's make this a Map<Identifier, Array<Place>> or . We shouldn't rely on loc.identifierName being present, and we don't want places with a non-existent loc.identiferName to all map to the same entry.

In this example, this logic works fine since setS is named and used explicitly (e.g. called right after a LoadLocal)

const [s, setS] = useState(...);
setS();

[mofeiZ]

shipit!

In a followup, let's change to use IdentifierId instead of source locations to key state setters.

[mofeiZ]

In a follow-up / when we decide to land this, let's also return and handle (log or throw) inside of the run function (in Pipeline) instead of throwing here