[Compiler] ValidateNoDerivedComputationsInEffects test cases #34574
+1,338
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-cab
changed the title
jorge-cab
force-pushed
the
pr34574
branch
3 times, most recently
from
5b75fc9 to
f3172ce
Compare
jorge-cab
force-pushed
the
pr34574
branch
3 times, most recently
from
6cc663d to
9d120ad
Compare
mofeiZ
reviewed
Oct 20, 2025
Comment on lines
+8
to
+15
| function Component({propValue}) { | ||
| const [value, setValue] = useState(null); | ||
| useEffect(() => { | ||
| setValue(propValue); | ||
| }, [propValue]); | ||
|
|
||
| return <MockComponent onSet={setValue} />; | ||
| } |
There was a problem hiding this comment.
Right, in this case we can't statically suggest a rewrite
mofeiZ
reviewed
Oct 20, 2025
|
|
||
| return ( | ||
| <div> | ||
| <input value={name} onChange={e => setName(e.target.value)} /> |
mofeiZ
reviewed
Oct 20, 2025
Comment on lines
+11
to
+14
| useEffect(() => { | ||
| setValue(propValue); | ||
| localFunction(); | ||
| }, [propValue]); |
There was a problem hiding this comment.
We're allowing this case because (1) we want to avoid false positives and (2) we don't want to analyze all local functions right(?)
There was a problem hiding this comment.
Yeah... I do think we should eventually analyze local functions at least the ones within the component, and maybe consider them setStates if they contain a nested setState I think we might want to take a closer look into localFunction now that I think about it
mofeiZ
reviewed
Oct 20, 2025
| const [value, setValue] = useState(null); | ||
| useEffect(() => { | ||
| setValue(propValue); | ||
| globalCall(); |
There was a problem hiding this comment.
Gotcha, in #34578 we remove this error
mofeiZ
approved these changes
Oct 20, 2025
Summary: This creates the test cases we expect this first iteration of calculate in render to catch The goal is to have tests that will be in a good state once we have the first iteration of the calculate in render validation working, which should be pretty limited in what its capturing. Test Plan: Test cases
jorge-cab
added a commit
that referenced
this pull request
Oct 23, 2025
…#34580) Summary: Change error and update snapshots The error now mentions what values are causing the issue which should provide better context on how to fix the issue --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34580). * __->__ #34580 * #34579 * #34578 * #34577 * #34575 * #34574
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…#34580) Summary: Change error and update snapshots The error now mentions what values are causing the issue which should provide better context on how to fix the issue --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34580). * __->__ #34580 * #34579 * #34578 * #34577 * #34575 * #34574 DiffTrain build for [09056ab](09056ab)
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…#34580) Summary: Change error and update snapshots The error now mentions what values are causing the issue which should provide better context on how to fix the issue --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34580). * __->__ #34580 * #34579 * #34578 * #34577 * #34575 * #34574 DiffTrain build for [09056ab](09056ab)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This creates the test cases we expect this first iteration of calculate in render to catch
The goal is to have tests that will be in a good state once we have the first iteration of the calculate in render validation working, which should be pretty limited in what its capturing.
Test Plan:
Test cases
Stack created with Sapling. Best reviewed with ReviewStack.