Skip to content

Use unique clap argument IDs #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use unique clap argument IDs #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/buck2_client/src/commands/debug/chrome_trace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pub struct ChromeTraceCommand {
// Hide because `event_log` below subsumes this.
hide = true
)]
pub path: Option<PathArg>,
pub event_log_path: Option<PathArg>,

#[clap(flatten)]
pub(crate) event_log: EventLogOptions,
Expand Down Expand Up @@ -1015,7 +1015,7 @@ impl BuckSubcommand for ChromeTraceCommand {
_events_ctx: &mut EventsCtx,
) -> ExitResult {
// For backward compatibility, use the path field if it's set
let log = if let Some(path) = self.path {
let log = if let Some(path) = self.event_log_path {
EventLogPathBuf::infer(path.resolve(&ctx.working_dir))?
} else {
self.event_log.get(&ctx).await?
Expand Down