Use unique clap argument IDs #1058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D79596226. (Because this pull request was imported automatically, there will not be any future comments.) |
|
this fixes #1029, please add a note in the commit message :) |
Running `buck2 debug chrome-trace` in debug mode would panic as clap has a debug assert to check for duplicate argument IDs. It is my understanding that duplicating argument IDs can cause bugs in release mode, even if they are under different subcommands. This also fixes the same panic that can occur during "buck2 completion zsh", issue facebook#1029.
bvinc
force-pushed
the
chrome_trace_event_log_arg
branch
from
07eea5d to
958597a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
buck2 debug chrome-tracein debug mode would panic as clap has a debug assert to check for duplicate argument IDs. It is my understanding that duplicating argument IDs can cause bugs in release mode, even if they are under different subcommands.