Skip to content

fix: allow faq accordion items to be toggled #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow faq accordion items to be toggled #1250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions website/src/routes/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export default component$(() => {
return (
<li key={heading} class="flex flex-col px-8">
<Form action={faqToggle}>
<input type="hidden" name="index" value={index} />
<input type="hidden" name="index" value={isOpen ? -1 : index} />
<button
class={clsx(
'focus-ring flex w-full justify-between space-x-4 rounded-md transition-colors focus-visible:outline-offset-[6px] focus-visible:ring-offset-8',
Expand All @@ -261,7 +261,6 @@ export default component$(() => {
: 'text-slate-800 hover:text-slate-700 dark:text-slate-300 hover:dark:text-slate-400'
)}
type="submit"
disabled={isOpen}
aria-expanded={isOpen}
aria-controls={`faq-${index}`}
>
Expand Down