fix: allow faq accordion items to be toggled #1250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
There was a problem hiding this comment.
Pull Request Overview
This PR enables FAQ accordion items to be toggled closed by updating the form payload and re-enabling the toggle button.
- Change the hidden input to send
-1when closing an open item - Remove the
disabledattribute from the toggle button
Comments suppressed due to low confidence (1)
website/src/routes/index.tsx:255
- Add a test case to verify that setting the hidden
indexto-1properly closes an open FAQ item and that the toggle behavior works as expected in future changes.
<input type="hidden" name="index" value={isOpen ? -1 : index} />
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small ux improvement for FAQ section, allow currently open item to be closed