Wait for handshake to finish to allow for clean disconnect when stopping reconnect logic #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncel If the connection has not established yet, we can cancel the connection process when the reconnect logic is stopped instead of waiting for the connection to fail. If we have already finished connecting and started the handshake, we wait for it to complete so we can try to disconnect cleanly
…ncel If the connection has not established yet, we can cancel the connection process when the reconnect logic is stopped instead of waiting for the connection to fail. If we have already finished connecting and started the handshake, we wait for it to complete so we can try to disconnect cleanly
…ncel If the connection has not established yet, we can cancel the connection process when the reconnect logic is stopped instead of waiting for the connection to fail. If we have already finished connecting and started the handshake, we wait for it to complete so we can try to disconnect cleanly
Codecov Report
@@ Coverage Diff @@
## main #614 +/- ##
==========================================
+ Coverage 77.41% 77.83% +0.41%
==========================================
Files 14 14
Lines 2488 2490 +2
==========================================
+ Hits 1926 1938 +12
+ Misses 562 552 -10
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
bdraco
changed the title
20 tasks
bdraco
added a commit
that referenced
this pull request
Nov 7, 2023
#614 fixed the case were we would cancel the handshake in progress, but it did not account for the race where we have not switched the state to connecting yet because we have not obtained the lock. While I could only get this to happen in a test its likely it possible in the real world if the timing is exactly perfect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a very rare race where we could disconnect in the middle of the handshake if we had just finished connecting to the ESP which would prevent the disconnect request from being seen by the ESP
To fix this we now only cancel without the lock if we are still establishing the connection, otherwise try to wait for the handshake to finish so we can cleanly disconnect.
This didn't cause any visible issues besides a log message on the esp