Allow the start task to be cancelled when already disconnected #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#614 fixed the case were we would cancel the handshake in progress, but it did not account for the race where we have not switched the state to connecting yet because we have not obtained the lock. While I could only get this to happen in a test its likely it possible in the real world if the timing is exactly perfect
Codecov Report
@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 77.41% 77.86% +0.45%
==========================================
Files 14 14
Lines 2488 2489 +1
==========================================
+ Hits 1926 1938 +12
+ Misses 562 551 -11
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Looks like we are going to end up with nearly full coverage for reconnect logic .. just one retest and PR at a time |
bdraco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#614 fixed the case were we would cancel the handshake in progress, but it did not account for the race where we have not switched the state to connecting yet because we have not obtained the lock. While I could only get this to happen in a test its likely it possible in the real world if the timing is exactly perfect