Implements Fetch in MuxCache
#1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MuxCache` doesn't implement the `Fetch` method and it returns an error. However `MuxCache` doesn't have any logic instead it delegates to the appropriate cache based on the request. This means that we can just use the same logic as `CreateWatch` to delegate to the appropriate cache's `Fetch` method. `Linear` cache doesnt implement `Fetch` either so this part of the call will fail but the rest of the caches will work as expected. Additionally it was a bit confusing to debug the issue since the error message resembles quite a bit a `gRPC Unimplemented` error. So I updated the error message in `Linear` cache to be more specific. Signed-off-by: sotiris <[email protected]>
Member
Author
|
@valerian-roche I see you are pretty active in the repo so I wonder if I can pester for you a code review 🙏 |
valerian-roche
previously approved these changes
Oct 27, 2025
pkg/cache/v3/linear.go
Outdated
|
|
||
| func (cache *LinearCache) Fetch(context.Context, *Request) (Response, error) { | ||
| return nil, errors.New("not implemented") | ||
| return nil, errors.New("Fetch is not implemented by LinearCache") |
Contributor
There was a problem hiding this comment.
Minor: most linters will trigger on capitalized error messages. Not sure if this goes through here as matching the method name though
Member
Author
There was a problem hiding this comment.
yeah not sure, how this slipped. My IDE also missed it
Signed-off-by: sotiris <[email protected]>
valerian-roche
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MuxCachedoesn't implement theFetchmethod and it returns an error. HoweverMuxCachedoesn't have any logic instead it delegates to the appropriate cache based on the request. This means that we can just use the same logic asCreateWatchto delegate to the appropriate cache'sFetchmethod.Linearcache doesnt implementFetcheither so this part of the call will fail but the rest of the caches will work as expected.Additionally it was a bit confusing to debug the issue since the error message resembles quite a bit a
gRPC Unimplementederror. So I updated the error message inLinearcache to be more specific.