Skip to content

Implements Fetch in MuxCache #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Implements Fetch in MuxCache #1326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a81bd4
Implements `Fetch` in `MuxCache`
davinci26 Oct 27, 2025
f31f0a3
make error lowercase
davinci26 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cache/v3/linear.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ func (cache *LinearCache) getVersion() string {
}

func (cache *LinearCache) Fetch(context.Context, *Request) (Response, error) {
return nil, errors.New("not implemented")
return nil, errors.New("Fetch is not implemented by LinearCache")
Copy link
Contributor

@valerian-roche valerian-roche Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: most linters will trigger on capitalized error messages. Not sure if this goes through here as matching the method name though

Copy link
Member Author

@davinci26 davinci26 Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah not sure, how this slipped. My IDE also missed it

}

// NumResources returns the number of resources currently in the cache.
Expand Down
12 changes: 9 additions & 3 deletions pkg/cache/v3/mux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ package cache

import (
"context"
"errors"
"fmt"
)

Expand Down Expand Up @@ -54,6 +53,13 @@ func (mux *MuxCache) CreateDeltaWatch(request *DeltaRequest, sub Subscription, v
return cache.CreateDeltaWatch(request, sub, value)
}

func (mux *MuxCache) Fetch(context.Context, *Request) (Response, error) {
return nil, errors.New("not implemented")
func (mux *MuxCache) Fetch(ctx context.Context, request *Request) (Response, error) {
key := mux.Classify(request)
cache, exists := mux.Caches[key]
if !exists {
return nil, fmt.Errorf("no cache defined for key %s", key)
}
// Not all caches may implement Fetch; we delegate to the selected cache and if
// it does not implement Fetch, it will return an error.
return cache.Fetch(ctx, request)
}