Skip to content

fix: increment valid_solved only after exclusion guards #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lance-Python-Dev wants to merge 1 commit into from
+3 −4
Closed

fix: increment valid_solved only after exclusion guards #1314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions gittensor/validator/issue_discovery/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,6 @@ async def _score_miner_issues(
)
continue

# Valid-solved gate: solving PR must meet the repo's token threshold.
if cached.token_score >= cfg.min_token_score_for_valid_issue:
acc.valid_solved += 1

# Same-account: discoverer == solver gets credibility only, no score
if issue.author_github_id == solving_pr.author_github_id:
bt.logging.debug(
Expand Down Expand Up @@ -494,6 +490,9 @@ async def _score_miner_issues(
)
continue

# Valid-solved gate: only increment after both exclusion guards pass
acc.valid_solved += 1

adapted = _mirror_issue_for_scoring(issue, solving_pr, repo_config, base_score=cached.base_score)
if adapted is None:
continue
Expand Down