fix: increment valid_solved only after exclusion guards#1314
Closed
Lance-Python-Dev wants to merge 1 commit into
Closed
fix: increment valid_solved only after exclusion guards#1314Lance-Python-Dev wants to merge 1 commit into
Lance-Python-Dev wants to merge 1 commit into
Conversation
Lance-Python-Dev
force-pushed
the
fix/valid-solved-after-guards
branch
from
9e69383 to
31f089f
Compare
Collaborator
|
Duplicate of #1299 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1298
valid_solved_countwas incremented before the same-account guard andthe canonical-PR-owner guard, allowing self-farmed and non-canonical
issues to inflate the eligibility counter.
Moved the increment to after both
continueguards so only issues thatsurvive all exclusion checks contribute to the valid-solved threshold.