Skip to content

fix(installation): replace find-then-insert with atomic upsert (#110) #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderdc merged 1 commit into from
May 20, 2026
Merged

fix(installation): replace find-then-insert with atomic upsert (#110) #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions packages/das/src/webhook/handlers/installation.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,22 +38,19 @@ export class InstallationHandler {
payload.repositories ?? payload.repositories_added ?? [];

for (const repo of repos) {
// Check existence first so we only set added_at on insert, not on every
// re-fire of installation.created / installation_repositories.added.
const existing = await this.repoRepo.findOneBy({
repoFullName: repo.full_name,
});
if (existing) {
await this.repoRepo.update(repo.full_name, {
installationId: String(installationId),
});
} else {
await this.repoRepo.insert({
// Atomic upsert: insert with addedAt on first encounter; on conflict only
// update installationId so addedAt is never overwritten on re-fires.
await this.repoRepo
.createQueryBuilder()
.insert()
.into(Repo)
.values({
repoFullName: repo.full_name,
installationId: String(installationId),
addedAt: new Date().toISOString(),
});
}
})
.orUpdate(["installationId"], ["repoFullName"])
.execute();
this.logger.log(`Tracking repo: ${repo.full_name}`);
}

Expand Down
Loading