fix(installation): replace find-then-insert with atomic upsert (#110)#111
Open
enjoyandlove wants to merge 1 commit into
Open
fix(installation): replace find-then-insert with atomic upsert (#110)#111enjoyandlove wants to merge 1 commit into
enjoyandlove wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the check-then-insert/update pattern in
InstallationHandlerwith a single atomic upsert. The previous implementation issued afindOneByfollowed by eitherinsertorupdate, which meant two round-trips and a potential race condition if the same installation event fired concurrently. The new approach uses acreateQueryBuilderupsert (.orUpdate) that inserts on first encounter — settingaddedAt— and only updatesinstallationIdon conflict, soaddedAtis never overwritten on re-fires ofinstallation.createdorinstallation_repositories.added.Related Issues
Fixes #110
Type of Change
Testing
installation.createdandinstallation_repositories.addedevents without error.addedAtunchanged and updatesinstallationIdcorrectly.Checklist