icon grid: Remove per-architecture blacklist #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keys in arch-blacklist.json are the autotools $(host_cpu) variable. The only key in that file is "arm". But nowadays we only support 64-bit ARM, for which $(host_cpu) is "aarch64". So this filter now does nothing. It doesn't matter, anyway, because the app grid code in Endless OS 3.9 and later just hides empty folders. Remove the blacklist logic, which also removes some problematic terminology from our distro.
- All Python dicts are now order-preserving. - makedirs() has an exist_ok argument. - argparse.FileType has actually been around for a long time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys in arch-blacklist.json are the autotools $(host_cpu) variable.
The only key in that file is "arm". But nowadays we only support 64-bit
ARM, for which $(host_cpu) is "aarch64". So this filter now does
nothing.
It doesn't matter, anyway, because the app grid code in Endless OS 3.9
and later just hides empty folders.
Remove the blacklist logic, which also removes some problematic
terminology from our distro.
While I was here I cleaned the JSON-mangling script a bit. You might notice that it is now a fancy
catthat performs a tiny amount of validation on the JSON. You might then think – can we just rename all the.json.infiles to.json, install them verbatim, and just syntax-check them at build time? And yes, we could, but I ran out of evening and appetite to think about Autotools. Update I filed #256 which I have barely tested.