Skip to content

Commit 3f60b3e

Browse files
authored
Merge pull request #255 from endlessm/icon-grid-remove-arch-blacklist
icon grid: Remove per-architecture blacklist
2 parents 4ffb25d + 92466c8 commit 3f60b3e

3 files changed

Lines changed: 7 additions & 34 deletions

File tree

data/Makefile.am

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ settings_in_files = $(wildcard settings/icon-grid-*.json.in)
66
settings_DATA = $(settings_in_files:.in=)
77
dist_noinst_SCRIPTS = settings/write-grid-json.py
88

9-
%.json: %.json.in settings/arch-blacklist.json settings/write-grid-json.py
9+
%.json: %.json.in settings/write-grid-json.py
1010
$(AM_V_GEN)$(srcdir)/settings/write-grid-json.py -o $@ \
11-
$< $(srcdir)/settings/arch-blacklist.json $(host_cpu)
11+
$<
1212

1313
do_subst = sed \
1414
-e 's|@PKG_DATA_DIR[@]|$(pkgdatadir)|g' \
@@ -21,7 +21,6 @@ eos-save-icon-grid: eos-save-icon-grid.in Makefile
2121
EXTRA_DIST = \
2222
$(folders_DATA) \
2323
$(settings_in_files) \
24-
settings/arch-blacklist.json \
2524
eos-save-icon-grid.in \
2625
$(NULL)
2726

data/settings/arch-blacklist.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

data/settings/write-grid-json.py

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,17 @@
11
#!/usr/bin/env python3
22

3-
from argparse import ArgumentParser
4-
from collections import OrderedDict
5-
import errno
3+
from argparse import ArgumentParser, FileType
64
import json
75
import os
86
import sys
97

108
aparser = ArgumentParser(description='Write icon grid json file')
119
aparser.add_argument('-o', '--output', help='output file')
12-
aparser.add_argument('input', help='input template file')
13-
aparser.add_argument('blacklist', help='blacklist file')
14-
aparser.add_argument('cpu', help='CPU for blacklisting')
10+
aparser.add_argument('input', help='input template file', type=FileType("r"))
1511
args = aparser.parse_args()
1612

17-
# Load with template and blacklist. Use OrderedDict for the grid to
18-
# maintain sorting of the keys.
19-
with open(args.input, 'r') as infile:
20-
grid = json.load(infile, object_pairs_hook=OrderedDict)
21-
with open(args.blacklist, 'r') as blfile:
22-
blacklist = json.load(blfile)
13+
# Load template
14+
grid = json.load(args.input)
2315

2416
# Open the a temporary version of the output file if specified, ensuring
2517
# that leading directories are created first.
@@ -28,22 +20,9 @@
2820
else:
2921
outdir = os.path.dirname(args.output)
3022
if len(outdir) > 0:
31-
try:
32-
os.makedirs(outdir)
33-
except OSError as err:
34-
if err.errno != errno.EEXIST:
35-
raise
23+
os.makedirs(outdir, exist_ok=True)
3624
outfile = open(args.output + '.tmp', 'w')
3725

38-
# Strip out blacklisted apps
39-
cpu_blacklist = blacklist.get(args.cpu, [])
40-
for app in cpu_blacklist:
41-
if app in grid:
42-
del grid[app]
43-
for sect, apps in grid.items():
44-
if app in apps:
45-
grid[sect].remove(app)
46-
4726
# Check that all directories are in the top-level "desktop" pseudo-directory
4827
desktop = grid["desktop"]
4928
for directory in grid:

0 commit comments

Comments
 (0)