Skip to content

[wasmfs] FetchFS: fix getFileRange out-of-bounds issues #24442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[wasmfs] FetchFS: fix getFileRange out-of-bounds issues #24442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lib/libwasmfs_fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,12 @@ addToLibrary({
// one request for all the chunks we need, rather than one
// request per chunk.
var start = firstChunk * chunkSize;

// Out of bounds. No request necessary.
if (start >= wasmFS$JSMemoryRanges[file].size) {
return Promise.resolve();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just use return here actually. See #24443

}

// We must fetch *up to* the last byte of the last chunk.
var end = (lastChunk+1) * chunkSize;
var response = await fetch(url, {headers:{'Range': `bytes=${start}-${end-1}`}});
Expand Down