[wasmfs] FetchFS: fix getFileRange out-of-bounds issues #24442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is authored by @foxtacles (See emscripten-core#24438) Fixes: emscripten-core#24438
sbc100
commented
May 29, 2025
|
|
||
| // Out of bounds. No request necessary. | ||
| if (start >= wasmFS$JSMemoryRanges[file].size) { | ||
| return Promise.resolve(); |
There was a problem hiding this comment.
I think we can just use return here actually. See #24443
kripken
approved these changes
May 29, 2025
|
More context: #24438 (comment) I'd suggest holding off merging this until there's been more investigation. I'll update you as soon as I had the chance to dig further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is authored by @foxtacles (See #24438)
Fixes: #24438