Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests virtual files #1890

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Add more tests virtual files #1890

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97fc382
test(virtual test-support): add a test to check this script is correc…
BlueCutOfficial Apr 24, 2024
567d933
test(virtual styles): add a test to check vendor.css and test-support…
BlueCutOfficial Apr 24, 2024
70035aa
test(virtual styles): make the build test able to find the CSS withou…
BlueCutOfficial Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 92 additions & 13 deletions tests/scenarios/compat-addon-classic-features-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import { throwOnWarnings } from '@embroider/core';
import { lstatSync, readFileSync } from 'fs';
import { readFile } from 'fs/promises';
import { merge } from 'lodash';
import QUnit from 'qunit';
import type { PreparedApp } from 'scenario-tester';
import fetch from 'node-fetch';
import globby from 'globby';
import { join } from 'path';

import { appScenarios, baseAddon } from './scenarios';
import CommandWatcher from './helpers/command-watcher';
Expand Down Expand Up @@ -135,36 +138,112 @@ appScenarios
appScenarios
.map('compat-addon-classic-features-virtual-scripts', () => {})
.forEachScenario(scenario => {
let app: PreparedApp;

Qmodule(`${scenario.name} - build mode`, function (hooks) {
hooks.before(async assert => {
Qmodule(scenario.name, function (hooks) {
let app: PreparedApp;
hooks.before(async () => {
app = await scenario.prepare();
});

test('virtual scripts are emitted in the build', async function (assert) {
let result = await app.execute('pnpm build');
assert.equal(result.exitCode, 0, result.output);
});

test('vendor.js script is emitted in the build', async function (assert) {
assert.true(lstatSync(`${app.dir}/dist/@embroider/core/vendor.js`).isFile());
assert.true(lstatSync(`${app.dir}/dist/@embroider/core/test-support.js`).isFile());
});
});

Qmodule(`${scenario.name} - dev mode`, function (hooks) {
hooks.before(async () => {
app = await scenario.prepare();
});

test('vendor.js script is served', async function (assert) {
test('virtual scripts contents are served in dev mode', async function (assert) {
const server = CommandWatcher.launch('vite', ['--clearScreen', 'false'], { cwd: app.dir });
try {
const [, url] = await server.waitFor(/Local:\s+(https?:\/\/.*)\//g);

let response = await fetch(`${url}/@embroider/core/vendor.js`);
assert.strictEqual(response.status, 200);
// checking the response status 200 is not enough to assert vendor.js is served,
// because when the URL is not recognized, the response contains the index.html
// and has a 200 status (for index.html being returned correctly)
let text = await response.text();
assert.true(!text.includes('<!DOCTYPE html>'));

response = await fetch(`${url}/@embroider/core/test-support.js`);
assert.strictEqual(response.status, 200);
// checking the response status 200 is not enough to assert test-support.js is served,
// because when the URL is not recognized, the response contains the index.html
// and has a 200 status (for index.html being returned correctly)
text = await response.text();
assert.true(!text.includes('<!DOCTYPE html>'));
} finally {
await server.shutdown();
}
});
});
});

appScenarios
.map('compat-addon-classic-features-virtual-styles', project => {
let myAddon = baseAddon();
myAddon.pkg.name = 'my-addon';
merge(myAddon.files, {
addon: {
styles: {
'addon.css': `
.my-addon-p { color: blue; }
`,
},
},
});
project.addDependency(myAddon);
})
.forEachScenario(scenario => {
Qmodule(scenario.name, function (hooks) {
let app: PreparedApp;
hooks.before(async () => {
app = await scenario.prepare();
});

test('virtual styles are included in the CSS of the production build', async function (assert) {
let result = await app.execute('pnpm build');
assert.equal(result.exitCode, 0, result.output);

// TODO: replace with an Audit when it's ready to take any given dist
let styles = await globby('dist/**/*.css', { cwd: app.dir });
let readResult = await Promise.all(
styles.map(async styleFile => {
let content = await readFile(join(app.dir, styleFile));
return content.toString().includes('.my-addon-p{color:#00f}');
})
);
assert.true(readResult.includes(true));
});

test('virtual styles are included in the CSS of the test build', async function (assert) {
let result = await app.execute('pnpm test');
assert.equal(result.exitCode, 0, result.output);

// TODO: replace with an Audit when it's ready to take any given dist
let styles = await globby('dist/**/*.css', { cwd: app.dir });
let readResult = await Promise.all(
styles.map(async styleFile => {
let content = await readFile(join(app.dir, styleFile));
return content.toString();
})
);
assert.true(readResult.some(content => content.includes('.my-addon-p{color:#00f}')));
assert.true(readResult.some(content => content.includes('#qunit-tests')));
});

test('virtual styles are served in dev mode', async function (assert) {
const server = CommandWatcher.launch('vite', ['--clearScreen', 'false'], { cwd: app.dir });
try {
const [, url] = await server.waitFor(/Local:\s+(https?:\/\/.*)\//g);

let response = await fetch(`${url}/@embroider/core/vendor.css?direct`);
let text = await response.text();
assert.true(text.includes('.my-addon-p { color: blue; }'));

response = await fetch(`${url}/@embroider/core/test-support.css?direct`);
text = await response.text();
assert.true(text.includes('#qunit-tests'));
} finally {
await server.shutdown();
}
Expand Down
Loading