Add more tests virtual files #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lty served and emitted
….css are served and built
…t hardcoding any filename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recently, several PRs have been merged that virtualize
vendor.css(#1805),test-support.js(#1807), andtest-support.css(#1811) files. These changes have been tested manually, but back then, we didn't add any new tests to assert the virtual contents are correctly served or present in the build output.This PR adds the missing tests.
About searching code in CSS files
The CSS-related tests should have ideally relied on the
Auditsystem to look for the pieces of styles that are expected to be present. But for now, this system presumes too many things about the location of the files we want to audit, it's not made to just take any givendist/. That's whyglobbyis used to retrieve all the CSS files in the build output and we read their content to find the expected styles.