Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to latest LTS (22.x) #198790

Open
legrego opened this issue Nov 4, 2024 · 8 comments · May be fixed by #205983
Open

Upgrade Node.js to latest LTS (22.x) #198790

legrego opened this issue Nov 4, 2024 · 8 comments · May be fixed by #205983
Assignees
Labels
chore Team:Operations Team label for Operations Team

Comments

@legrego
Copy link
Member

legrego commented Nov 4, 2024

Node.js recently bumped their Active LTS line to version 22. We should upgrade from version 20, which is now in maintenance mode:

Image

We should plan for this to land no later than the last minor release for 8.x, so that our last supported version of 8 aligns with 9.

Potentially unblocks #106868

@legrego legrego added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team labels Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@legrego legrego mentioned this issue Nov 5, 2024
2 tasks
@rudolf
Copy link
Contributor

rudolf commented Nov 6, 2024

As far as I can tell there isn't obvious breaking changes that should affect us. So I'll remove the Core label for now. If it turns out that we need to make any changes within Core we can of course help out with that.

@rudolf rudolf removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Nov 6, 2024
@azasypkin
Copy link
Member

Btw, since Node.js 21, the fetch API has been marked as stable, so once we migrate to Node.js 21, we can finally start recommending switching to native fetch instead of axios & friends.

@mistic
Copy link
Member

mistic commented Dec 12, 2024

Just a note for Ops team when we look into doing this upgrade. We should not go past v22.11.0 for now at least until v22.15.0 is out so we can give some time for the CJS/ESM interop releases on v22.12.0 to mature.

@jbudz
Copy link
Member

jbudz commented Jan 15, 2025

#205983 is mostly ready. See linked meta issue for more details.

I'm pausing for now based on #198790 (comment).

@legrego and @mistic maybe you can sync on timeline and required versions? It would be helpful to not delay getting this into 8.x if that's a pre-release requirement. Can we not use the ESM feature for now, instead of waiting until 22.15.0?

@legrego
Copy link
Member Author

legrego commented Jan 15, 2025

@legrego and @mistic maybe you can sync on timeline and required versions? It would be helpful to not delay getting this into 8.x if that's a pre-release requirement. Can we not use the ESM feature for now, instead of waiting until 22.15.0?

I believe we need to have this upgrade in all versions of 8.x that we plan to support in a 9.x era (Is that just 8.last, or does it include 8.last - 1?). I am fine to delay using the ESM feature until we deem it "ready".

jsanz added a commit that referenced this issue Jan 16, 2025
## Summary

Related to elastic/ems-client#543 and
#198790

Updates `@elastic/[email protected]` adding support for Node 22.x
jsanz added a commit to jsanz/kibana that referenced this issue Jan 16, 2025
## Summary

Related to elastic/ems-client#543 and
elastic#198790

Updates `@elastic/[email protected]` adding support for Node 22.x

(cherry picked from commit 2345872)

# Conflicts:
#	package.json
#	src/dev/license_checker/config.ts
jsanz added a commit that referenced this issue Jan 16, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Maps] Update @elastic/ems-client to 8.6.3
(#206814)](#206814)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jorge
Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:46:37Z","message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","backport:prev-minor","Feature:Maps"],"title":"[Maps]
Update @elastic/ems-client to
8.6.3","number":206814,"url":"https://github.com/elastic/kibana/pull/206814","mergeCommit":{"message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206814","number":206814,"mergeCommit":{"message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422"}}]}] BACKPORT-->
@jbudz
Copy link
Member

jbudz commented Jan 16, 2025

I believe we need to have this upgrade in all versions of 8.x that we plan to support in a 9.x era (Is that just 8.last, or does it include 8.last - 1?). I am fine to delay using the ESM feature until we deem it "ready".

Thanks. I added --no-experimental-require-module to distributions to disable it.

viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
## Summary

Related to elastic/ems-client#543 and
elastic#198790

Updates `@elastic/[email protected]` adding support for Node 22.x
@jbudz jbudz self-assigned this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants