Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node.js to 22.13.1 #205983

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Upgrade Node.js to 22.13.1 #205983

wants to merge 53 commits into from
+122 −75

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jan 9, 2025 •
edited
Loading

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Jan 9, 2025
@jbudz
Copy link
Member Author

jbudz commented Jan 10, 2025

@elastic/kibana-reporting-services, cc @dokmic if you get a chance can you help with
[job] [logs] Jest Integration Tests #4 / PdfMaker generate should generate PDF array buffer

I made a pass but it's out of my expertise and don't want to cause a memory regression

DataCloneError: Cannot transfer object of unsupported type.
    at new DOMException (node:internal/per_context/domexception:53:5)
    at postMessage (/opt/buildkite-agent/builds/bk-agent-prod-gcp-1736456796993925274/elastic/kibana-pull-request/kibana/x-pack/platform/plugins/shared/screenshotting/server/formats/pdf/pdf_maker/pdfmaker.ts:257:16)

Implemented at #136537
Upstream change https://github.com/nodejs/node/issues/55593

@jbudz jbudz requested review from a team as code owners January 24, 2025 23:58
@jbudz jbudz requested a review from xcrzx January 24, 2025 23:58
afharo
afharo approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM. Code review only

package.json
@@ -1678,7 +1679,7 @@
"@types/webpack-sources": "^0.1.4",
"@types/xml2js": "^0.4.11",
"@types/yargs": "^15.0.0",
"@types/yauzl": "^2.9.1",
"@types/yauzl": "^2.10.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems odd that the types are v2 and the library v3. Maybe these are not needed anymore?

Copy link
Member Author

@jbudz jbudz Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting - they're still needed. The missing changes aren't too extensive fortunately, it looks like there are missing definitions for a few methods we aren't using.

https://github.com/DefinitelyTyped/DefinitelyTyped/tree/ffe46d9382e765fc0f54530b4653e57e6ef0921c/types/yauzl
https://github.com/thejoshwolfe/yauzl?tab=readme-ov-file#change-history

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 25, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

sabarasaba
sabarasaba approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana management changes lgtm

jennypavlova
jennypavlova approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs UX infra and services changes LGTM (code review only)

pheyos
pheyos approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-es-archiver/src/lib/archives/parse.test.ts changes LGTM

@jbudz jbudz added the skip-ci label Jan 28, 2025
@jbudz
Merge pull request #3 from eokoneyo/node-22
a00e0d6 
Ensure image buffers passed to the worker spun to generate a PDF request is transferrable
@jbudz jbudz removed the skip-ci label Jan 28, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 28, 2025 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #58 / Cloud Security Posture Agentless Security Posture Integration Options should show cspm with agentless option
  • [job] [logs] FTR Configs #58 / Cloud Security Posture Agentless Security Posture Integration Options should show cspm with agentless option
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

History

juliaElastic
juliaElastic approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

bhapas
bhapas approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic Import test changes LGTM

delanni
delanni approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

tsullivan
tsullivan approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reporting changes LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eokoneyo eokoneyo eokoneyo left review comments

@adcoelho adcoelho adcoelho approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@thomheymann thomheymann thomheymann approved these changes

@xcrzx xcrzx xcrzx approved these changes

@pheyos pheyos pheyos approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@delanni delanni delanni approved these changes

@afharo afharo afharo approved these changes

@tsullivan tsullivan tsullivan approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

@bhapas bhapas bhapas approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:all-cypress-suites ci:build-all-platforms ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-redeploy Always create a new Cloud project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Node.js to latest LTS (22.x)