Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js 22 support #543

Closed
jbudz opened this issue Jan 8, 2025 · 1 comment · Fixed by #552
Closed

Node.js 22 support #543

jbudz opened this issue Jan 8, 2025 · 1 comment · Fixed by #552
Assignees
@jsanz

Comments

@jbudz
Copy link
Member

jbudz commented Jan 8, 2025 •
edited
Loading

elastic/kibana#198790

We're looking into upgrading Kibana to Node.js 22 but can't install this package due to

ems-client/package.json

Line 74 in cd38af0

"node": ">=18 <=20"

Would it be possible to add support for v22?
@jsanz jsanz self-assigned this Jan 15, 2025
@jsanz jsanz mentioned this issue Jan 15, 2025
Merged
@jsanz
Copy link
Member

jsanz commented Jan 15, 2025

Thanks for the ping @jbudz, opened #552 to upgrade the library. After merge I'll do a patch release and open the corresponding PR in Kibana for upgrade.

@jsanz jsanz mentioned this issue Jan 15, 2025
Merged
jsanz added a commit to elastic/kibana that referenced this issue Jan 16, 2025
@jsanz
[Maps] Update @elastic/ems-client to 8.6.3 (#206814)
2345872 
## Summary

Related to elastic/ems-client#543 and
#198790

Updates `@elastic/[email protected]` adding support for Node 22.x
jsanz added a commit to jsanz/kibana that referenced this issue Jan 16, 2025
@jsanz
[Maps] Update @elastic/ems-client to 8.6.3 (elastic#206814)
98fc1b3 
## Summary

Related to elastic/ems-client#543 and
elastic#198790

Updates `@elastic/[email protected]` adding support for Node 22.x

(cherry picked from commit 2345872)

# Conflicts:
#	package.json
#	src/dev/license_checker/config.ts
jsanz added a commit to elastic/kibana that referenced this issue Jan 16, 2025
@jsanz
[8.x] [Maps] Update @elastic/ems-client to 8.6.3 (#206814) (#206908)
df6fa91 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Maps] Update @elastic/ems-client to 8.6.3
(#206814)](#206814)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jorge
Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T08:46:37Z","message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","backport:prev-minor","Feature:Maps"],"title":"[Maps]
Update @elastic/ems-client to
8.6.3","number":206814,"url":"https://github.com/elastic/kibana/pull/206814","mergeCommit":{"message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206814","number":206814,"mergeCommit":{"message":"[Maps]
Update @elastic/ems-client to 8.6.3 (#206814)\n\n## Summary\n\nRelated
to elastic/ems-client#543
and\nhttps://github.com//issues/198790\n\nUpdates
`@elastic/[email protected]` adding support for Node
22.x","sha":"2345872393d3ec21f0bfe8b76c729edd46d69422"}}]}] BACKPORT-->
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@jsanz @viduni94
[Maps] Update @elastic/ems-client to 8.6.3 (elastic#206814)
08f07c2 
## Summary

Related to elastic/ems-client#543 and
elastic#198790

Updates `@elastic/[email protected]` adding support for Node 22.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsanz jsanz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Node 22 jsanz/ems-client
2 participants
@jsanz @jbudz