[EuiFlyoutResizable] Allow consumers to update the size prop
#7759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
flyout-resizable/controlled-size
branch
from
bfae62d to
1e759f6
Compare
- currently `size` stops being respected after the first time a user resizes the flyout - this should work for both controlled sizes `onResize` as well as semi-uncontrolled resizing (`size` never updates)
cee-chen
force-pushed
the
flyout-resizable/controlled-size
branch
from
1e759f6 to
6579d4d
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
mgadewoll
approved these changes
May 15, 2024
| }, [flyoutRef, getFlyoutMinMaxWidth, size]); | ||
| setCallOnResize(false); | ||
| // For string `size`s, resetting flyoutWidth to 0 will trigger the above useEffect's recalculation | ||
| setFlyoutWidth(typeof size === 'number' ? getFlyoutMinMaxWidth(size) : 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #7536
Currently,
sizestops updating/being respected after the first time a user resizes the flyout. I've tweaked theuseEffects of the resizable flyout component slightly to allow consumers to control/override the internal flyout width state.QA
sizeprop, and change it (e.g. tos,l,2000px,400, etc)General checklist
jest andcypress tests- [ ] If applicable, added the breaking change issue label (and filled out the breaking change checklist)