Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v94.5.0 #183431

Merged
merged 7 commits into from
May 20, 2024
Merged

Upgrade EUI to v94.5.0 #183431

merged 7 commits into from
May 20, 2024

Conversation

tkajtoch
Copy link
Member

@tkajtoch tkajtoch commented May 14, 2024

v94.3.0v94.5.0-backport.1

Questions? Please see our Kibana upgrade FAQ.


v94.5.0-backport.1

This is a backport release only intended for use by Kibana.

v94.5.0

  • EuiFlyoutResizable now respects size prop updates, allowing for controlled size usage (#7759)

Bug fixes

  • Restored a removed setTimeout in EuiInputPopover to reduce flaky Cypress failures (#7760)

Accessibility

  • EuiToolTips can now additionally be dismissed via Escape keypress as well as on focus blur. (#7751)

v94.4.1

  • Added support for toolTipContent and toolTipProps props on EuiSelectable options (#7715)
  • Updated EuiSuperDatePicker's absolute tab UX to support setting manual timestamps via mouse click as well as enter key (#7732)

Bug fixes

  • Fixed issue with unmounted component state updates on requestAnimationFrame for EuiSelectable (#7715)
  • Fixed EuiMarkdownEditor not disabling the upload dropzone when in readOnly mode (#7738)
  • Fixed EuiMarkdownEditor not showing an invalid underline on the editor when errors are present (#7738)

CSS-in-JS conversions

  • Converted EuiMarkdownEditor to Emotion; Removed $euiMarkdownEditorMinHeight (#7738)
  • Fully converted EuiMarkdownFormat to Emotion (#7738)

Accessibility

  • Updated EuiCollapsedNavButton with improved context for screen reader navigation (#7740)

ℹ️ There's no code difference between v94.4.0 and v94.4.1. v94.4.0 was published to npm without the README included, and v94.4.1 fixes that.

@tkajtoch tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This commit does not require backporting v8.15.0 labels May 14, 2024
@tkajtoch tkajtoch self-assigned this May 14, 2024
@tkajtoch tkajtoch changed the title Upgrade EUI to v94.4.1 Upgrade EUI to v94.5.0 May 15, 2024
@banderror banderror requested a review from nikitaindik May 16, 2024 08:30
@banderror
Copy link
Contributor

Adding @nikitaindik to reviewers to double-check that elastic/eui#7760 fixes our tests.

Thanks for the quick patch @tkajtoch! ❤️

@tkajtoch tkajtoch force-pushed the feat/eui-94.4.1 branch 3 times, most recently from f8e2c05 to b2b26af Compare May 17, 2024 15:44
@tkajtoch tkajtoch marked this pull request as ready for review May 17, 2024 19:43
@tkajtoch tkajtoch requested review from a team as code owners May 17, 2024 19:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team!

@tkajtoch
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 409.6KB 409.8KB +176.0B
kbnUiSharedDeps-css 254.0KB 241.1KB -12.9KB
kbnUiSharedDeps-npmDll 6.3MB 6.3MB +20.3KB
kbnUiSharedDeps-srcJs 3.1MB 3.1MB +1.0B
total +7.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeowner changes lgtm

Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM.
Thanks for deleting the associated translations!

@tkajtoch tkajtoch merged commit 83345c5 into elastic:main May 20, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants