Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7418: Two instances of incorrect 2nd parseFloat parameter #7419

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Fix #7418: Two instances of incorrect 2nd parseFloat parameter #7419

merged 5 commits into from
Dec 18, 2023

Conversation

dannya
Copy link
Contributor

@dannya dannya commented Dec 13, 2023 •
edited by cee-chen
Loading

closes #7418

@dannya dannya requested a review from a team as a code owner December 13, 2023 00:16
@github-actions GitHub Actions
Copy link

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@dannya dannya mentioned this pull request Dec 13, 2023
Closed
@cee-chen
Copy link
Contributor

buildkite test this

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Dec 13, 2023
@cee-chen
Copy link
Contributor

Nice catch, thank you dannya! Adding for more context:

  • parseInt(number, 10) is valid, but parseFloat isn't
  • We should likely make these documentation files tsx so typescript helps us catch errors like this

@cee-chen cee-chen enabled auto-merge (squash) December 13, 2023 18:35
@cee-chen
Copy link
Contributor

buildkite test this

@cee-chen
Copy link
Contributor

buildkite test this

@kibanamachine
Copy link

Preview staging links for this PR:

@cee-chen cee-chen merged commit f34b19f into elastic:main Dec 18, 2023
7 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
community contribution documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] [DOCS] Two instances of incorrect 2nd parseFloat parameter
4 participants
@dannya @cee-chen @kibanamachine @elasticmachine