Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [DOCS] Two instances of incorrect 2nd parseFloat parameter #7418

Closed
dannya opened this issue Dec 13, 2023 · 1 comment · Fixed by #7419
Closed

[BUG] [DOCS] Two instances of incorrect 2nd parseFloat parameter #7418

dannya opened this issue Dec 13, 2023 · 1 comment · Fixed by #7419

Comments

@dannya
Copy link
Contributor

dannya commented Dec 13, 2023

parseFloat does not have a 2nd radix parameter (unlike parseInt) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat

eui/src-docs/src/views/datagrid/schema_columns/footer_row.js

Line 31 in d70d459

10

eui/src-docs/src/views/datagrid/basics/datagrid.js

Line 76 in d70d459

10

dannya added a commit to dannya/eui that referenced this issue Dec 13, 2023
@dannya
[DOCS] Fix two instances of incorrect 2nd parseFloat parameter.
537a89a 
Fix elastic#7418
@dannya
Copy link
Contributor Author

dannya commented Dec 13, 2023 •
edited
Loading

Pull request to fix: #7419

@cee-chen cee-chen mentioned this issue Dec 13, 2023
Merged
cee-chen pushed a commit that referenced this issue Dec 18, 2023
@dannya
Fix #7418: Two instances of incorrect 2nd parseFloat parameter (#7419)
f34b19f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7418: Two instances of incorrect 2nd parseFloat parameter dannya/eui
1 participant
@dannya