build: deploy new docs #7409
Merged
build: deploy new docs #7409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1Copenut
reviewed
Dec 7, 2023
scripts/deploy/deploy_docs
Outdated
Comment on lines
58
to
59
| - Storybook: https://eui.elastic.co/pr_${GIT_PULL_REQUEST_ID}/storybook | ||
| - New docs site (in development): https://eui.elastic.co/pr_${GIT_PULL_REQUEST_ID}/new-docs" |
There was a problem hiding this comment.
This URL doesn't have the trailing / at the end of the Docusaurus link, and I think that's what's causing the docs header to display twice when the URL resolves to /new-docs/index.html. If I add the trailing slash, it shows the header properly and has the same URL as the EUI logo in the docs preview site.
There was a problem hiding this comment.
Yeah, this is strange. I'm testing some configuration variations to see if we can fix it without forcing that slash there just in case it would cause troubles when deployed to / in the future
tkajtoch
force-pushed
the
feat/deploy-new-docs
branch
from
0210750 to
445db1f
Compare
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @tkajtoch |
tkajtoch
added a commit
that referenced
this pull request
Dec 13, 2023
tkajtoch
added a commit
to tkajtoch/eui
that referenced
this pull request
Jan 22, 2024
tkajtoch
added a commit
that referenced
this pull request
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #7402 by updating
build_docsanddeploy_docsto build the new docs site and deploy it undernew-docsdirectory.QA